Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XPU support for AOT inductor #1503

Merged
merged 25 commits into from
Feb 27, 2025
Merged

Add XPU support for AOT inductor #1503

merged 25 commits into from
Feb 27, 2025

Conversation

jenniew
Copy link
Contributor

@jenniew jenniew commented Feb 24, 2025

Add XPU support for AOT inductor.

Copy link

pytorch-bot bot commented Feb 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1503

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 6 Pending, 1 Unrelated Failure

As of commit 6bece4f with merge base d3cd165 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 24, 2025
if [[ -x "$(command -v xpu-smi)" ]];
then
(
set -x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse the conditional on line 84?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because line 84 is to install using pytorch xpu link: https://download.pytorch.org/whl/nightly/xpu. Since we don't have torchtune nightly for xpu now, we temporarily to install torchtune cpu nightly from cpu link: https://download.pytorch.org/whl/nightly/cpu. After xpu nightly is ready, we'll update line 84 to install from pytorch xpu link.

Copy link
Contributor

@Jack-Khuu Jack-Khuu Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I meant reuse the if [[ -x "$(command -v xpu-smi)" ]]; check

This PR is fine to merge as-is though since after we get torchtune nightly this is going to be removed anyways 😃

@Jack-Khuu Jack-Khuu merged commit 4251a54 into pytorch:main Feb 27, 2025
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants