Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial for gpu quantization using torchao #2730

Merged
merged 58 commits into from
Feb 6, 2024
Merged

Conversation

HDCharles
Copy link
Contributor

Description

Added a prototype tutorial for gpu quantization on SAM

Checklist

  • [x ] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • [x ] Only one issue is addressed in this pull request
  • [x ] Labels from the issue that this PR is fixing are added to this pull request
  • [x ] No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Jan 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2730

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7c05b6b with merge base e96a8a9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Here is an editorial pass - let me know if you have any questions.

@HDCharles HDCharles added the 2.2 label Jan 12, 2024
@HDCharles HDCharles requested a review from svekars January 12, 2024 22:59
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new data dependencies to download.py rather than to a makefile

HDCharles and others added 20 commits January 25, 2024 19:38
Summary: Optimizing and Quantizing hte SAM model

Test Plan: ran the tutorial file successfully

Reviewers:

Subscribers:

Tasks:

Tags:
Co-authored-by: Svetlana Karslioglu <[email protected]>
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@HDCharles
Copy link
Contributor Author

I compared the build logs for the PR vs a working one (https://github.com/pytorch/tutorials/actions/runs/7657752323/job/20869170562?pr=2747)

PR:
25h Created wheel for gym: filename=gym-0.26.2-py3-none-any.whl size=827619 sha256=4586c6c675f4aeac11710f4a00cecd7774b31133e21d9937f071a0e5e71240f0

vs
working:
25h Created wheel for gym: filename=gym-0.26.2-py3-none-any.whl size=827624 sha256=baa10b04ef1f7368625f75d5c383f27766105219708c3960f1d4ecb65b297ebf

@malfet is that possible to be the culprit, its the same version, how could the size be different?

@malfet
Copy link
Contributor

malfet commented Jan 26, 2024

@HDCharles Gym is installed from source, trying to debug what is going on

@HDCharles HDCharles mentioned this pull request Jan 27, 2024
@svekars svekars merged commit b09d465 into main Feb 6, 2024
19 checks passed
@svekars svekars deleted the 099_gpu_quant branch February 6, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants