Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick #8524 into r2.6 #8572

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Cherrypick #8524 into r2.6 #8572

merged 1 commit into from
Jan 15, 2025

Conversation

tengyifei
Copy link
Collaborator

Cherrypick 0289022 into r2.6

@tengyifei tengyifei changed the base branch from master to r2.6 January 14, 2025 23:26
@tengyifei tengyifei mentioned this pull request Jan 14, 2025
Open
@tengyifei tengyifei requested a review from ManfeiBai January 14, 2025 23:27
@tengyifei tengyifei marked this pull request as ready for review January 14, 2025 23:27
ManfeiBai
ManfeiBai approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@tengyifei tengyifei merged commit c7902e3 into r2.6 Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfeiBai ManfeiBai ManfeiBai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tengyifei @ManfeiBai