Enable User to view Raw Data for their measurements #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownload information and methods
…hod and adapt css accordingly
…om/qbicsoftware/data-manager-app into feature/dm-414-browse-raw-datasets
…ion (Without openbis though)
KochTobi
reviewed
Mar 25, 2024
...-management/src/main/java/life/qbic/projectmanagement/application/rawdata/RawDataLookup.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/life/qbic/projectmanagement/application/rawdata/RawDataLookupService.java
Outdated
Show resolved
Hide resolved
...management/src/main/java/life/qbic/projectmanagement/application/rawdata/RawDataService.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/life/qbic/projectmanagement/application/sample/SampleInformationService.java
Show resolved
Hide resolved
...management/src/main/java/life/qbic/projectmanagement/application/rawdata/RawDataService.java
Show resolved
Hide resolved
...ent/src/main/java/life/qbic/projectmanagement/application/measurement/MeasurementLookup.java
Show resolved
Hide resolved
...a/life/qbic/datamanager/views/projects/project/measurements/MeasurementDetailsComponent.java
Show resolved
Hide resolved
...ain/java/life/qbic/datamanager/views/projects/project/rawdata/RawDataURLContentProvider.java
Outdated
Show resolved
Hide resolved
…pplication/rawdata/RawDataService.java Co-authored-by: Tobias Koch <[email protected]>
Co-authored-by: Tobias Koch <[email protected]>
…ants and provide columns in grid
Co-authored-by: wow-such-code <[email protected]>
… Id check in template column
|
| @@ -29,6 +30,11 @@ public Optional<String> assignedSamplePoolGroup() { | |||
| return Optional.ofNullable(samplePoolGroup.isBlank() ? null : samplePoolGroup); | |||
| } | |||
|
|
|||
| @Override | |||
| public MeasurementCode measurementCode() { | |||
| return null; | |||
| this.experimentInformationService = Objects.requireNonNull(experimentInformationService); | ||
| this.measurementService = Objects.requireNonNull(measurementService); | ||
| this.rawDataService = Objects.requireNonNull(rawDataService); | ||
| this.rawDataSourceURL = Objects.requireNonNull(dataSourceURL); |
There was a problem hiding this comment.
this is an empty string for me, I reckon this is just a settings issue?
There was a problem hiding this comment.
...or not yet implemented
wow-such-code
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
1.) Introduced a dedicated view which will enable a user to view the data generated for their measurements
2.) Provide the correct empty state disclaimers if no samples/measurment were registered
3.) Add Url Generation and download for data download:
How to test
Provide values for the environment variables employed to handle the openbis connection containing the data:
"openbis.datasource.as.url=${OPENBIS_ASS_URL:}"
"openbis.datasource.dss.url=${OPENBIS_DSS_URL:}"
"server.download.api.measurement.url=${DOWNLOAD_MEASUREMENT_API_URL:}"
1.) Go to Project 007 and switch to enabled raw data tab and observe raw data information!
2.) Try to download files with generated urls for raw data