Experimental Variable and Group Cards sizing stays consistent independent of screen size #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r experimental variables and groups
This was
linked to
issues
Sep 30, 2024
|
|
The PR solves the original issue, hence I will approve it. However I do not understand, why we address an issue of many variables, which imo is an artificial problem. As users already told us, most of them will have probably 1-3 variables. This will then look like this on a 4k screen: 
Maybe @Shraddha0903 , this is something worth to rethink? |
sven1103
approved these changes
Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
In the current build, the cards try to resize dependent on the screen width. This can lead to content overflow.
Screen.Recording.2024-09-05.at.16.37.57.mov
This PR aims to fix this by allowing the css grid to easier adjust the card position if the screen width changes:
Screen.Recording.2024-09-05.at.16.38.30.mov
Open Question
Why is the overflow not in the card collection itself?
For this i opened a seperate issue #826 , since it relates to how the data manager application handles component sizing.
Currently we don't enforce a screen width and height for the content container. Therefore the components can grow in size, leading to an overflow scrollbar on the content container. To change this an entire rewrite of the application structure would be necessary.