Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare smaller 1.6.1 release with minor improvements #910

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

sven1103
Copy link
Contributor

No description provided.

Steffengreiner and others added 3 commits November 14, 2024 14:20
…nk orcId (#833)

* Show orcId if present for users in their profile and provide hook for orcid Linkage if possible

* Remove anchor for orcid Linkage

* Incorporate PR Feedback

---------

Co-authored-by: wow-such-code <[email protected]>
Co-authored-by: Tobias Koch <[email protected]>
Co-authored-by: Sven F. <[email protected]>
Addresses 17 reliability concerns raised by SonarCloud and fixes several maintainability issues.

---------

Co-authored-by: Tobias Koch <[email protected]>
Introduces the concept of a Collapsable element, harmonizing and paving the way for future elements we want to be collapsed / expanded.

The example implementation addresses #904 and improves the objective display.
---------
Co-authored-by: Tobias Koch <[email protected]>
@sven1103 sven1103 requested a review from a team as a code owner November 18, 2024 11:52
@KochTobi KochTobi changed the title Prepare smaller 1.6.1 release with minor improvments Prepare smaller 1.6.1 release with minor improvements Nov 18, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@KochTobi
Copy link
Member

@sven1103 and @Shraddha0903
Is it desired that the objective field does not show line breaks? During editing line breaks are visible.

Copy link
Member

@KochTobi KochTobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KochTobi KochTobi merged commit d515a68 into main Nov 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants