Show comments for NGS and ProteomicsMeasurements #962
Conversation
…s-don't-show-comment
…s-don't-show-comment
|
@Steffengreiner what is the related issue? Please always link the corresponding issue in the PR via GitHub's x-ref feature: |
|
Heya @sven1103, Thanks for the Feedback. I linked the issue in question 👍 |
| @@ -186,18 +186,18 @@ private void createNGSMeasurementGrid() { | |||
| .setAutoWidth(true) | |||
| .setFlexGrow(0); | |||
| ngsMeasurementGrid.addComponentColumn(measurement -> { | |||
| if (measurement.samplePoolGroup().isEmpty()) { | |||
| if (!measurement.isPooledSampleMeasurement()) { | |||
There was a problem hiding this comment.
Negations are harder to read and understand, especially that "!" is not part our natural language. I suggest to include a method like isSingleSampleMeasurement() to reflect the positive case you are looking for.
| if (!measurement.isPooledSampleMeasurement()) { | ||
| Span singularComment = new Span(); | ||
| singularComment.setText( | ||
| measurement.specificMeasurementMetadata().stream().findFirst().orElseThrow().comment() |
There was a problem hiding this comment.
I am not sure what happens here. I also think, that we should handle the orElseThrow() with care, since it will cause exceptions that are not of importance.
There was a problem hiding this comment.
thank you @Steffengreiner !
Some minor requests, questions before it is ready to merge
…roteomics and NGS measurements
|
sven1103
deleted the
feature/dm-938-proteomics-measurements-don't-show-comment
branch
What was changed
Currently the Proteomics and Ngs Measurements don't show the provided comments during measurement registration. This error appears for pooled and unpooled measurements.
This PR aims to provide the comments for singular Samples within the measurement overview, while providing the possiblity to open the information dialog for pooled samples