Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex toggle for WEBUI torrent filtering #20566

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

HamletDuFromage
Copy link
Contributor

@HamletDuFromage HamletDuFromage commented Mar 17, 2024

I've added a simple toggle for regex searches. It already exists on the desktop version but not on the WebUI

image

image

image

The logic is pretty hacky here HamletDuFromage@8560fb2#diff-855d251c4b031d765c3989ddca46e6454501d2f2f5a4313788cb3bcd016c6fe6R1440-R1449, but it works. I just didn't want to change applyFilter()

The icon comes from here https://iconduck.com/icons/20674/regex and is licensed under the ISC. It's kind of a placeholder right now I guess

@luzpaz luzpaz added the WebUI WebUI-related issues/changes label Mar 17, 2024
@luzpaz
Copy link
Contributor

luzpaz commented Mar 17, 2024

Lint error:

private/css/style.css
 420:5  ✖  Expected margin-bottom to come before width               order/properties-alphabetical-order
 421:5  ✖  Expected background-image to come before margin-bottom    order/properties-alphabetical-order
 433:5  ✖  Expected margin-bottom to come before width               order/properties-alphabetical-order
 434:5  ✖  Expected background-image to come before margin-bottom    order/properties-alphabetical-order
 438:5  ✖  Expected background-color to come before background-size  order/properties-alphabetical-order

src/webui/www/private/scripts/client.js Outdated Show resolved Hide resolved
src/webui/www/webui.qrc Outdated Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
@Chocobo1 Chocobo1 requested a review from a team March 19, 2024 18:29
@Chocobo1 Chocobo1 added this to the 5.0 milestone Mar 19, 2024
@luzpaz
Copy link
Contributor

luzpaz commented Mar 20, 2024

macos CI is failing, is it related to the PR ?

@HamletDuFromage
Copy link
Contributor Author

macos CI is failing, is it related to the PR ?

ERROR: Bundle creation error: "hdiutil: create failed - Resource busy\n"
I can't imagine it is

@Chocobo1 Chocobo1 merged commit 5c67c5a into qbittorrent:master Mar 24, 2024
12 of 13 checks passed
@Chocobo1
Copy link
Member

@HamletDuFromage
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants