Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize completer for file system path widget on demand #20586

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Initialize completer for file system path widget on demand #20586

merged 1 commit into from
Mar 23, 2024

Conversation

glassez
Copy link
Member

@glassez glassez commented Mar 21, 2024

This should save some resources and prevent unnecessary access to the file system.

@glassez glassez added the GUI GUI-related issues/changes label Mar 21, 2024
@glassez glassez added this to the 5.0 milestone Mar 21, 2024
@glassez glassez requested a review from a team March 21, 2024 12:54
@glassez glassez requested a review from a team March 21, 2024 13:53
@glassez
Copy link
Member Author

glassez commented Mar 22, 2024

@sledgehammer999, @Chocobo1
Can I backport this PR?

@Chocobo1
Copy link
Member

Chocobo1 commented Mar 22, 2024 •
edited
Loading

Can I backport this PR?

I think you should since it greatly affects the user experience if I'm not mistaken. Does it prevent the UI hang in some cases?

@glassez
Copy link
Member Author

glassez commented Mar 22, 2024

Can I backport this PR?

I think you should since it greatly affects the user experience if I'm not mistaken. Does it prevent the UI hang in some cases?

Does it prevent the UI hang in some cases?

It prevents the UI hang like #20581 if you didn't touch path edit widgets (and even if you did use them without touching completer).

@glassez glassez modified the milestones: 5.0, 4.6.4 Mar 23, 2024
@glassez glassez merged commit 25b7972 into qbittorrent:master Mar 23, 2024
13 checks passed
@glassez glassez deleted the path-completer branch March 23, 2024 05:18
glassez added a commit to sledgehammer999/qBittorrent that referenced this pull request Mar 23, 2024
@glassez
Initialize completer for file system path widget on demand
753cdfd 
PR qbittorrent#20586.
@glassez glassez mentioned this pull request Mar 23, 2024
Merged
@glassez
Copy link
Member Author

glassez commented Jun 18, 2024

Does it prevent the UI hang in some cases?

It prevents the UI hang like #20581 if you didn't touch path edit widgets (and even if you did use them without touching completer).

QTBUG-122719 that causes such a problem is declared as fixed in Qt 6.6.3 and 6.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier2k6 xavier2k6 xavier2k6 approved these changes

@sledgehammer999 sledgehammer999 sledgehammer999 approved these changes

Assignees
No one assigned
Labels
GUI GUI-related issues/changes
Projects
None yet
Milestone
4.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@glassez @Chocobo1 @sledgehammer999 @xavier2k6