Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA CI: check python scripts #20590

Merged
merged 3 commits into from
Mar 25, 2024
Merged

GHA CI: check python scripts #20590

merged 3 commits into from
Mar 25, 2024

Conversation

Chocobo1
Copy link
Member

  • GHA CI: check python scripts
  • Apply formatting

The python scripts in this repo is slowly increasing and I reckon it would be good to have some basic checks (linting & styling PEP8) in CI.

ps. I intend to use 'create a merge commit' strategy when merging.

@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Mar 22, 2024
@Chocobo1 Chocobo1 added this to the 5.0 milestone Mar 22, 2024
Copy link
Member

@sledgehammer999 sledgehammer999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I have never used update_qrc_files.py and I think it is a very old artifact.
Unless something else uses it, I propose just deleting the file.

@Chocobo1
Copy link
Member Author

Personally I have never used update_qrc_files.py and I think it is a very old artifact.
Unless something else uses it, I propose just deleting the file.

OK, removed in another commit.

@Chocobo1
Copy link
Member Author

@sledgehammer999
Do you mind that we delete merge-requests/15 branch? https://github.com/qbittorrent/qBittorrent/tree/merge-requests/15
This branch does not contain any new commit. Github says: This branch is 8810 commits behind master.

@sledgehammer999
Copy link
Member

@sledgehammer999 Do you mind that we delete merge-requests/15 branch? https://github.com/qbittorrent/qBittorrent/tree/merge-requests/15 This branch does not contain any new commit. Github says: This branch is 8810 commits behind master.

Go ahead. Probably a left over from the very early days.

@Chocobo1
Copy link
Member Author

Go ahead. Probably a left over from the very early days.

It is done.

@Chocobo1 Chocobo1 requested a review from a team March 23, 2024 05:57
@Chocobo1 Chocobo1 merged commit f2d6129 into qbittorrent:master Mar 25, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the py branch March 25, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants