-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA CI: check python scripts #20590
GHA CI: check python scripts #20590
Conversation
8e5ce1e
to
2f9a792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I have never used update_qrc_files.py
and I think it is a very old artifact.
Unless something else uses it, I propose just deleting the file.
OK, removed in another commit. |
@sledgehammer999 |
Go ahead. Probably a left over from the very early days. |
It is done. |
The python scripts in this repo is slowly increasing and I reckon it would be good to have some basic checks (linting & styling PEP8) in CI.
ps. I intend to use 'create a merge commit' strategy when merging.