Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OptimizeAlignment #21293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stalkerok
Copy link
Contributor

This will allow to create torrent files with a sequential file structure (1. 2. 3. rather than 3. 1. 2.). This is the default behavior in lt2.0.

@Chocobo1
Copy link
Member

Chocobo1 commented Sep 6, 2024

This will allow to create torrent files with a sequential file structure (1. 2. 3. rather than 3. 1. 2.).

You can just untick the "Optimize alignment" checkbox in torrent creator. Also this option is intended to be on by default.

@stalkerok
Copy link
Contributor Author

The problem is that users create torrent files with default settings, and then complain that qBittorrent does not respect the file order. They don't know what this feature does and prefer sequential file order (there was a discussion on one tracker). Is there any reason why this should be enabled by default?

@Chocobo1
Copy link
Member

Chocobo1 commented Sep 6, 2024

Is there any reason why this should be enabled by default?

https://github.com/arvidn/libtorrent/blob/v1.2.19/include/libtorrent/create_torrent.hpp#L107-L110

Also, from https://www.libtorrent.org/upgrade_to_2.0-ref.html#create-torrent-changes :

All v2 torrents have pieces aligned to files, so the optimize_alignment flag is no longer relevant (as it's effectively always on).

@stalkerok
Copy link
Contributor Author

I've read this before, but I don't understand why this behavior is necessarily the default? This change only affects lt1.2, which does not support v2. When creating a v1 torrent in lt2.0, the files are in sequential order.

@Chocobo1
Copy link
Member

Chocobo1 commented Sep 6, 2024

I've read this before, but I don't understand why this behavior is necessarily the default?

The points are "optimized disk-I/O" and "minimize the number of bytes of pad-files".

When creating a v1 torrent in lt2.0, the files are in sequential order.

This might be a bug in libtorrent.

This change only affects lt1.2, which does not support v2.

Yes but IMO it is better that the current default behavior is consistent with the new format. When v2 format become widespread (if that day ever comes), users will have to learn/face it eventually.

IIRC that option has been on for a long time. And do you really think we should change it now? Why not let users learn that checkbox existence?

@stalkerok
Copy link
Contributor Author

And do you really think we should change it now?

Yes.

Why not let users learn that checkbox existence?

This will not happen. The option has been enabled for a long time and users still do not know what is gained by disabling this checkbox.

Yes but IMO it is better that the current default behavior is consistent with the new format. When v2 format become widespread (if that day ever comes), users will have to learn/face it eventually.

It's going to take a very long time if v2 really ever becomes popular. I'm relying on current discussions.

@Chocobo1
Copy link
Member

Chocobo1 commented Sep 6, 2024

Why not let users learn that checkbox existence?

This will not happen. The option has been enabled for a long time and users still do not know what is gained by disabling this checkbox.

We have related changes in 2018, it is really nothing new to the public: #8742

Maybe lack of auxiliary information? We can improve it such as adding description in tool tip.

And do you really think we should change it now?

Yes.

OK. I don't really support this change but nor do I block it. You'll need other members to support it.

@Chocobo1 Chocobo1 added Core GUI GUI-related issues/changes and removed Core labels Sep 6, 2024
@Chocobo1 Chocobo1 requested a review from a team September 6, 2024 20:14
@stalkerok
Copy link
Contributor Author

Maybe lack of auxiliary information? We can improve it such as adding description in tool tip.

I don't think it's going to help. Users will only know about it when they get burned by it.

BTW, I found a good comment #5652 (comment)

@stalkerok
Copy link
Contributor Author

Does anyone on the members support this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants