Display error in WebUI when download fails #21696
Open
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
reviewed
Oct 31, 2024
Piccirello
force-pushed
the
webui-torrent-export
branch
2 times, most recently
from
7af8ea9
to
91084b6
Compare
Chocobo1
reviewed
Nov 9, 2024
Piccirello
force-pushed
the
webui-torrent-export
branch
from
91084b6
to
42ac1c4
Compare
Chocobo1
reviewed
Nov 16, 2024
Previously we would still download the file but it would contain the error response. Signed-off-by: Thomas Piccirello <[email protected]>
Piccirello
force-pushed
the
webui-torrent-export
branch
from
42ac1c4
to
57946ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would still download the file but it would contain the error response, resulting in an invalid file.
To test: export a .torrent file for a torrent that hasn't yet downloaded metadata