Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify hash of Python installer #21877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Verify hash of Python installer #21877

wants to merge 1 commit into from
+70 −13

Conversation

Chocobo1
Copy link
Member

No description provided.

@Chocobo1 Chocobo1 added the Search engine Issues related to the search engine/search plugins functionality label Nov 19, 2024
@Chocobo1 Chocobo1 added this to the 5.1 milestone Nov 19, 2024
glassez
glassez reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would extract the code into separate function bool verifyPythonInstaller(const Path &installerPath).

src/gui/mainwindow.cpp Outdated Show resolved Hide resolved
src/gui/mainwindow.cpp Outdated Show resolved Hide resolved
@Chocobo1
Copy link
Member Author

I would extract the code into separate function bool verifyPythonInstaller(const Path &installerPath).

Done.

@Chocobo1 Chocobo1 requested a review from a team November 19, 2024 13:14
@thalieht thalieht added the OS: Windows Issues specific to Windows label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OS: Windows Issues specific to Windows Search engine Issues related to the search engine/search plugins functionality
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Chocobo1 @glassez @thalieht