Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update HTTP downloads algorithms #9337

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Oct 31, 2024

Fixes #9282, fixes #9212

@signedav, may I request a review? Thanks.

@DelazJ DelazJ added Processing Alg (Features of) An algorithm. Use the Help button in the application to find the page. backport release_3.40 On merge create a backported pull request to 3.40 labels Oct 31, 2024
In other words you can copy/paste a URL and download the file.
Download file via HTTP(S)
----------------------------
Downloads a URL to the file system with an HTTP(S) GET or POST request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Downloads a URL to the file system with an HTTP(S) GET or POST request.
Downloads a file specified using a URL with an HTTP(S) GET or POST request.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... This was somehow the previous description, and I'm now just following the new description in the GUI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. Then leave it. The GUI text was reviewed by a native english speaker (Nyall) so I guess it's right.

@DelazJ DelazJ merged commit 348b7cc into qgis:master Nov 5, 2024
2 of 3 checks passed
@DelazJ DelazJ deleted the filetoolsAlgs branch November 5, 2024 09:32
DelazJ added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3.40 On merge create a backported pull request to 3.40 Processing Alg (Features of) An algorithm. Use the Help button in the application to find the page.
Projects
None yet
2 participants