Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[annotations] Add support for callouts to point text, rect text and picture items #58295

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

nyalldawson
Copy link
Collaborator

Allows creating of callout lines (or bubble callouts) which link the text to a map location. To create a callout, users select the text item and then drag out the central x node to the desired callout end point.

Callout styles can be modified through the layer styling panel.

Peek.2024-08-02.13-32.mp4

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Aug 2, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Aug 2, 2024

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Aug 2, 2024

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions github-actions bot added this to the 3.40.0 milestone Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 38a1de4)

src/gui/qgsrubberband.h Show resolved Hide resolved
* The anchor dictates the geometry which the option item callout() should connect to. Depending on the
* callout subclass and anchor geometry type, the actual shape of the rendered callout may vary.
*
* The callout anchor geometry is in the parent layer's coordinate reference system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For project annotations, that would be the project CRS? Might be worth expanding here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always the layer's CRS. The main annotation layer for a project still has it's own CRS, which may or may not be the same as the project's CRS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson , fair enough.

@nyalldawson nyalldawson changed the title [annotations] Add support for callouts to point text item [annotations] Add support for callouts to point text, rect text and picture items Aug 5, 2024
Allows creating of callout lines (or bubble callouts) which
link the text to a map location. To create a callout, users
select the text item and then drag out the central x node
to the desired callout end point.

Callout styles can be modified through the layer styling panel.
@nyalldawson nyalldawson merged commit 590c213 into qgis:master Aug 6, 2024
30 checks passed
@nyalldawson nyalldawson deleted the annotation_callout branch August 6, 2024 03:30
@qgis-bot
Copy link
Collaborator

qgis-bot commented Aug 6, 2024

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9194
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants