Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the milestone during issue report creation for docs repo #59295

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Oct 31, 2024

calling the existing action in the workflow

As you can see in qgis/QGIS-Documentation#9319 and qgis/QGIS-Documentation#9318, the reported version is 3.40 instead of 3.42, meaning that #57421 which is supposed to update the version number during merging didn't work as expected. This PR provides an alternative approach.

@github-actions github-actions bot added this to the 3.42.0 milestone Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit b2bd09c)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit b2bd09c)

@nyalldawson nyalldawson merged commit b6ab304 into qgis:master Oct 31, 2024
32 checks passed
@DelazJ DelazJ deleted the pr4MilestoneDocs_caller branch November 4, 2024 11:08
@DelazJ
Copy link
Contributor Author

DelazJ commented Nov 11, 2024

Well, this doesn't work: #59061 should have had its milestone/version set to 3.42 but it didn't. As far as I understand, this is due to the way the milestone is set: only PRs that NOT YET have a milestone assigned get one. For years, this would boil down IMHO to the last newly created PR.
I think the logic in pr-auto-milestone action should be modified to tackle only the active (triggering) PR (and not browse all opened?) and thus allow to update its milestone if required.
Would the analysis be correct and the suggestion accepted, I could give it a try (not that I fully understand all the steps there yet, but I can try...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants