-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix render order of symbol layers for filled marker/filled line/arrow subsymbol #60575
Fix render order of symbol layers for filled marker/filled line/arrow subsymbol #60575
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
If a filled marker had eg a centroid fill marker in the subsymbol, this would always be rendered on top, regardless of the actual defined order
7b57c95
to
dc57c94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for addressing this.
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_40 release-3_40
# Navigate to the new working tree
cd .worktrees/backport-release-3_40
# Create a new branch
git switch --create backport-60575-to-release-3_40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 39f6824203b4654aa236ef46b212d7b823c8dd1b,553c8e984128bedca01ba460fe582ed2c162d328,fb6ba9289d62ca6768fd6a3c362cb4540c3f832a,dc57c94962302894ab1f4f618ccde58c07edd2be
# Push it to GitHub
git push --set-upstream origin backport-60575-to-release-3_40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_40 Then, create a pull request where the |
If a filled marker/filled line/arrow line had eg a centroid fill marker in the subsymbol, this would always be rendered on top, regardless of the actual defined order