Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for coverage #130

Merged
merged 3 commits into from
Jan 31, 2024
Merged

add test case for coverage #130

merged 3 commits into from
Jan 31, 2024

Conversation

zhengjian526
Copy link
Collaborator

#119

  1. add coverage filter for file "string_view.hpp" and "nonstd_any.hpp";
  2. add test case for client async callback and publish and subscribe by token;
  3. add server error callback

* add test case for client async callback
* add coverage filter
add test case for client async callback
add coverage filter
add client publish and subscribe by token
add client util test
Copy link

Code Coverage Report
for detail, goto summary download Artifacts

Filename                    Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
client_util.hpp                     3                 1    66.67%          19                 8    57.89%           2                 1    50.00%
codec.h                             4                 0   100.00%          24                 2    91.67%           0                 0         -
connection.h                       39                 6    84.62%         375                91    75.73%          72                36    50.00%
io_service_pool.h                   5                 0   100.00%          32                 1    96.88%          12                 1    91.67%
md5.hpp                            19                 2    89.47%         127                 8    93.70%          24                 0   100.00%
nonstd_any.hpp                     20                 5    75.00%          49                12    75.51%           8                 4    50.00%
router.h                           19                 2    89.47%         144                35    75.69%           4                 3    25.00%
rpc_client.hpp                     73                12    83.56%         663               143    78.43%         132                58    56.06%
rpc_server.h                       26                 3    88.46%         191                20    89.53%          40                 9    77.50%
string_view.hpp                    23                10    56.52%          72                35    51.39%          22                14    36.36%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             231                41    82.25%        1696               355    79.07%         316               126    60.13%

@codecov-commenter
Copy link

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (07d5735) 53.32% compared to head (ab27c06) 54.30%.

Files Patch % Lines
tests/test_rest_rpc.cpp 83.92% 18 Missing ⚠️
include/rest_rpc/rpc_server.h 84.61% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   53.32%   54.30%   +0.97%     
==========================================
  Files         170      170              
  Lines        7908     8038     +130     
==========================================
+ Hits         4217     4365     +148     
+ Misses       3691     3673      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit 4fb707c into qicosmos:master Jan 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants