Skip to content

Commit

Permalink
clean useless warnings (#153)
Browse files Browse the repository at this point in the history
  • Loading branch information
nighca authored Nov 3, 2021
1 parent 7cd4ae9 commit 0c2eec5
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 21 deletions.
34 changes: 28 additions & 6 deletions src/utils/webpack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Configuration, WebpackPluginInstance, Chunk, RuleSetRule, RuleSetCondit
import chunks from '../constants/chunks'
import { Optimization } from './build-conf'
import { getCachePath } from './paths'
import logger from './logger'

/** 向配置中追加 plugin */
export function appendPlugins(config: Configuration, ...plugins: Array<WebpackPluginInstance | null | undefined>) {
Expand Down Expand Up @@ -41,13 +42,15 @@ export function adaptLoader({ loader, options }: LoaderInfo): LoaderInfo {
return loaderObj
}

const sourcemapParseFailedWarningPattern = /Failed to parse source map from/

/** 配置 source map */
export function processSourceMap(previousConfig: Configuration, highQuality: boolean) {
return produce(previousConfig, (config: Configuration) => {
export function processSourceMap(config: Configuration, highQuality: boolean) {
config = produce(config, (newConfig: Configuration) => {
// 使用 cheap-module-source-map 而不是 eval-cheap-module-source-map 或 eval-source-map
// 具体原因见 https://github.com/Front-End-Engineering-Cloud/builder/pull/139#discussion_r676475522
config.devtool = highQuality ? 'cheap-module-source-map' : 'eval';
config.module!.rules!.push({
newConfig.devtool = highQuality ? 'cheap-module-source-map' : 'eval';
newConfig.module!.rules!.push({
test: /node_modules\/.*\.js$/,
enforce: 'pre',
use: [{
Expand All @@ -60,8 +63,16 @@ export function processSourceMap(previousConfig: Configuration, highQuality: boo
}
}
}].map(adaptLoader)
});
});
})
})
if (highQuality) {
// 第三方依赖的 source map 信息残缺导致 parse 失败是很常见的事情,
// 最常见的原因是生成的 sourcemap 未将源码 inline,而发布的内容里也没有包含源码,
// 详见 https://www.typescriptlang.org/tsconfig/#inlineSources
// 这里忽略相关 warning,避免污染浏览器 console
config = ignoreWarning(config, sourcemapParseFailedWarningPattern)
}
return config
}

export interface SplitChunksCacheGroup {
Expand Down Expand Up @@ -205,3 +216,14 @@ export function enableFilesystemCache(config: Configuration): Configuration {
}
})
}

/** 指定 pattern 忽略 warning */
export function ignoreWarning(config: Configuration, pattern: RegExp): Configuration {
return produce(config, newConfig => {
newConfig.ignoreWarnings ??= []
if (!newConfig.ignoreWarnings.includes(pattern)) {
logger.debug('append warningsFilter:', pattern)
newConfig.ignoreWarnings.push(pattern)
}
})
}
17 changes: 2 additions & 15 deletions src/webpack/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import {
AddPolyfill, shouldAddRuntimePolyfill
} from '../utils/build-conf'
import { Env, getEnv } from '../utils/build-env'
import logger from '../utils/logger'
import { LoaderInfo, adaptLoader, makeRule, addDefaultExtension } from '../utils/webpack'
import { LoaderInfo, adaptLoader, makeRule, addDefaultExtension, ignoreWarning } from '../utils/webpack'

// ts-loader 开启 transpileOnly 后会出的 warning
const tsTranspileOnlyWarningPattern = /export .* was not found in/
Expand Down Expand Up @@ -273,19 +272,7 @@ function addTransform(
if (tsLoaderOptions.transpileOnly) {
// 干掉因为开启 transpileOnly 导致的 warning
// 详情见 https://github.com/TypeStrong/ts-loader#transpileonly
config = produce(config, newConfig => {
newConfig.stats ??= {}
if (typeof(newConfig.stats) === 'boolean' || typeof(newConfig.stats) === 'string') {
throw new Error("Expect config.stats to be object.")
}
const originFilter = newConfig.stats.warningsFilter ?? []
const warningsFilter = Array.isArray(originFilter) ? originFilter : [originFilter]
if (!warningsFilter.includes(tsTranspileOnlyWarningPattern)) {
logger.debug('append warningsFilter:', tsTranspileOnlyWarningPattern)
warningsFilter.push(tsTranspileOnlyWarningPattern)
newConfig.stats.warningsFilter = warningsFilter
}
})
config = ignoreWarning(config, tsTranspileOnlyWarningPattern)
}
return appendRuleWithLoaders(
config,
Expand Down

0 comments on commit 0c2eec5

Please sign in to comment.