Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In transpile options, set routing = "none" #13

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

kevinsung
Copy link
Collaborator

I think the optimization level can be left to the default. Routing should not be performed, so we set it to "none".

@nkanazawa1989
Copy link
Collaborator

I think disabling the gate optimization is also important. If we optimize the gate depending on angles, it could induce nonuniform error contribution and diverge the curve. In principle, GEM experiment measures the trend of metrics against the drift from Clifford limit, and we should assume underlying physical error is constant. @ehchen please confirm.

@kevinsung
Copy link
Collaborator Author

I think disabling the gate optimization is also important. If we optimize the gate depending on angles, it could induce nonuniform error contribution and diverge the curve. In principle, GEM experiment measures the trend of metrics against the drift from Clifford limit, and we should assume underlying physical error is constant. @ehchen please confirm.

In that case, we should actually set optimization_level = 0, right?

@kevinsung kevinsung changed the title In transpile options, set routing = "none" and don't set optimization_level In transpile options, set optimization_level = 0 and routing = "none" Oct 1, 2024
@kevinsung kevinsung changed the title In transpile options, set optimization_level = 0 and routing = "none" In transpile options, set routing = "none" Oct 1, 2024
@kevinsung
Copy link
Collaborator Author

Ok after further discussion, we should keep optimization_level = 1 so that single-qubit gates are optimized.

@kevinsung
Copy link
Collaborator Author

@nkanazawa1989 does the PR as is look good to you?

Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Usually routing is not called because the circuit is coupling aware and the PM has a checker pass before calling routing. Perhaps there could be some edge case that the experiment makes edge between non-coupled qubits though. With this change PM can raise an error instead of inserting SWAPs.

@kevinsung kevinsung merged commit b07f300 into main Oct 5, 2024
14 checks passed
@kevinsung kevinsung deleted the transpile-opts branch October 5, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants