Port Qiskit Metal from PySide2 to PySide6 #908
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ubuntu unit tests
Hoping this will resolve an issue with running tests and doc building
|
When this is merged, it will resolve #798. |
|
|
|
@priti-ashvin-shah-ibm @obrienpja Hi all, Is there any timeline on when this PR will be accepted? Best, |
|
I think we need a little help from somebody to test it on their end and make sure everything works as intended. Would you be up to help with this? |
|
I have tested this PR and it is not quite ready for acceptance since it fails on a number of tests... However I think I can resolve those issues and will make a PR with that instead. Best, |
|
That would be fantastic. Thank you. Keep us posted. |
|
@zlatko-minev I made the PR - #1002 (comment) - with the fixes. It passes all the automated checks and also my custom workflow checks. |
|
Great we'll move the discussion there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
Porting Qiskit Metal from PySide2 to PySide6
Did you add tests to cover your changes (yes/no)?
No, but I don't think we have any tests for the GUI itself anyway
Did you update the documentation accordingly (yes/no)?
No, none of the examples should be affected
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
The commits change all of the PySide2 imports to PySide6 imports. It also changes the matplotlib backend from Qt5Agg to QtAgg.
Details and comments
A couple of classes were moved in PySide6. For example, QAction moved from QtWidgets in PySide2 to QtGui in PySide6. We also needed to change the backend that handles the rendering of matplotlib from Qt5Agg to QtAgg. According to their documentation, the QtAgg backend should be able to handle the connection between any version of Qt and matplotlib. From what I remember, they are doing their best to make it agnostic.