Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pid from master pidfile name. Closes #20. #28

Closed
wants to merge 1 commit into from

Conversation

strk
Copy link
Contributor

@strk strk commented Dec 11, 2012

There's no use of a .pid file storing the PID if you need to know
the PID in order to read the file...

There's no use of a .pid file storing the PID if you need to know
the PID in order to read the file...
@strk
Copy link
Contributor Author

strk commented Dec 11, 2012

NOTE: the TravisCI failure is due to unstable test results, independently from the patch.
Simply applying this patch fixes the test here:

diff --git a/test/cluster-test.js b/test/cluster-test.js
index 3ebe6e5..282f3ab 100644
--- a/test/cluster-test.js
+++ b/test/cluster-test.js
@@ -354,7 +354,7 @@ module.exports = {
                 var re = new RegExp('status=AVAILABLE&ServeTraffic=true&ip=(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)&hostname=' + hostname + '&port=3000&time=.*');
                 var result = re.exec(body);
                 test.ok(result !== null,
-                    'expected:status=AVAILABLE&ServeTraffic=true&ip=<Network IP>&hostname=' + hostname + '&port=3000&time=.*');
+                    'expected:status=AVAILABLE&ServeTraffic=true&ip=<Network IP>&hostname=' + hostname + '&port=3000&time=.*' +"");

                 request({uri: 'http://localhost:3000/ecv/disable', method: 'POST'}, function (error, response, body) {
                     // Wait for signal to propagate to workers

The patch is only appending an empty string to the failure message !

@strk
Copy link
Contributor Author

strk commented Jan 29, 2013

Tried a rebase with #31 -- does pass npm test for me

@strk strk closed this Jan 29, 2013
@strk strk deleted the master-pidfile branch January 29, 2013 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants