This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Add EventBus navigation to UI5 XACE - XML App Component With EventBus #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi DJ, This is more of a question than anything else so feel free to ignore this pull request. ;-)
I was wondering why you state that the two app templates use the EventBus. It seems that instead you are coupling each "child" controller to the "root" controller for navigation.
If you use the EventBus as per the SDK's "best practices" it would look like my pull request here... I've added it as another template "...With EventBus".
If I debug into the bowels of the navigation - deep, deep, down, the .to() and .back() methods do internally use the EventBus anyway but its not visible when looking at the code...
So - what is the best practice? The code between each is not particularly cleaner one way or the other; though by coupling the controllers its probably two or three lines less all up. What do you think is the best way to go?