Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new keyboard - jcpm2 (JC Pro Macro 2) #24816

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Added a new keyboard - jcpm2 (JC Pro Macro 2) #24816

wants to merge 33 commits into from
+327 −0

Conversation

JeremySCook
Copy link

New keyboard (macro pad)

New keyboard

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x ] Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Jan 15, 2025
View reviewed changes
keyboards/jcpm2/config.h Outdated Show resolved Hide resolved
keyboards/jcpm2/keyboard.json Outdated Show resolved Hide resolved
keyboards/jcpm2/keyboard.json Show resolved Hide resolved
keyboards/jcpm2/keyboard.json Outdated Show resolved Hide resolved
keyboards/jcpm2/keyboard.json Outdated Show resolved Hide resolved
keyboards/jcpm2/keyboard.json Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/readme.md Outdated Show resolved Hide resolved
keyboards/jcpm2/rules.mk Outdated Show resolved Hide resolved
drashna
drashna requested changes Jan 15, 2025
View reviewed changes
keyboards/jcpm2/config.h Outdated Show resolved Hide resolved
keyboards/jcpm2/keyboard.json Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/rules.mk Outdated Show resolved Hide resolved
@JeremySCook JeremySCook marked this pull request as ready for review January 16, 2025 02:23
waffle87
waffle87 reviewed Jan 16, 2025
View reviewed changes
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/jcpm2.c Outdated Show resolved Hide resolved
@JeremySCook JeremySCook requested a review from waffle87 January 16, 2025 02:33
zvecr
zvecr requested changes Jan 16, 2025
View reviewed changes
keyboards/jcpm2/keyboard.json Outdated Show resolved Hide resolved
keyboards/jcpm2/config.h Outdated Show resolved Hide resolved
keyboards/jcpm2/jcpm2.c Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/jcpm2.c Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/readme.md Outdated Show resolved Hide resolved
keyboards/jcpm2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jcpm2/jcpm2.c Outdated Show resolved Hide resolved
keyboards/jcpm2/jcpm2.c Outdated Show resolved Hide resolved
JeremySCook and others added 10 commits January 15, 2025 21:43
@JeremySCook @zvecr
Update keyboards/jcpm2/keyboard.json
fddda74 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/jcpm2.c
38da75a 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/config.h
43eb6a1 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/jcpm2.c
4ab5db3 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/keymaps/default/keymap.c
6bdeeb7 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/readme.md
46a623f 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/keymaps/default/keymap.c
f777b41 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/jcpm2.c
7825b93 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/keymaps/default/keymap.c
372e1fa 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook @zvecr
Update keyboards/jcpm2/jcpm2.c
7e099cd 
Co-authored-by: Joel Challis <[email protected]>
@JeremySCook JeremySCook requested a review from zvecr January 16, 2025 02:47
@JeremySCook JeremySCook requested a review from zvecr January 16, 2025 13:10
@drashna drashna requested a review from a team January 16, 2025 18:23
@JeremySCook
Copy link
Author

JeremySCook commented Jan 18, 2025 •
edited
Loading

Since I added the QMK screen to the keyboard at the beginning via jcpm2.c, I've noticed that it pops up every once in a while on top of my current layer. Thinking the timer is rolling over, so will change it to a 32 bit value.

Also changed timer_elapsed to timer_elapsed32 per suggestion. Loaded on my macro pad and will monitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 Awaiting requested review from waffle87

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeremySCook @drashna @zvecr @waffle87