Skip to content

Commit

Permalink
Merge pull request #468 from qonto/drop-node-16
Browse files Browse the repository at this point in the history
feat: drop node v16
  • Loading branch information
vscav authored Nov 14, 2023
2 parents 98e1ba3 + 454e9d7 commit 4c4283e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Lint
run: pnpm lint
Expand All @@ -41,7 +41,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--no-lockfile"
- name: Run tests
run: pnpm test
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Run tests
run: pnpm ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
Expand All @@ -99,7 +99,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Update TS version on addon package
run: pnpm add -D ${{ matrix.typescript-scenario }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ npm install --save-dev ember-autofocus-modifier

- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v16 or above
- Node.js v18 or above
- TypeScript v5.0 or above

## TypeScript usage
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"release-it": "^15.11.0"
},
"engines": {
"node": "16.* || >= 18"
"node": ">= 18"
},
"volta": {
"node": "18.14.2"
Expand Down
2 changes: 1 addition & 1 deletion test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"webpack": "5.88.2"
},
"engines": {
"node": "16.* || >= 18"
"node": ">= 18"
},
"ember": {
"edition": "octane"
Expand Down

0 comments on commit 4c4283e

Please sign in to comment.