ci: add README for LAVA test plans #128
Conversation
mwasilew
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
| `ci/lava` directory contains directories with names corresponding to build MACHINE names. | ||
| New directories should only be added after the build is available for a given MACHINE. | ||
| All files in the `ci/lava/<MACHINE>` directory should have `.yaml` extension. | ||
| Each file should be a valid LAVA job template. |
There was a problem hiding this comment.
Is there a way to validate the job template?
There was a problem hiding this comment.
Easiest is to submit it to LAVA through UI. There is a validator script - part of LAVA sources, but it's not standalone and it's hard to use. There is also an API, so in theory I can validate the files as part of github wokflow:
https://lava.infra.foundries.io/api/v0.2/jobs/validate/
Do you think it's a good idea?
There was a problem hiding this comment.
My main concern here is mostly to document how to validate the files, don't need something fancy. Just extending here saying how you / someone can validate would be fine.
There was a problem hiding this comment.
Is there a YAML schema for those files? It can be used for validation.
There was a problem hiding this comment.
There is. There is also a validator in LAVA code: https://gitlab.com/lava/lava/-/tree/master/lava_common/schemas?ref_type=heads. Templates can be validated using the running server, but it requires password in HTTP call. I guess the easiest way to use the existing LAVA implementation would be to call the lava container in github action. I'll try to propose additional check. We'll need to keep the version of the server in sync with the check though. It's a minor issue as schema rarely changes these days.
There was a problem hiding this comment.
I added a script. This should trigger an action checking the templates.
mwasilew
force-pushed
the
ci-lava-readme
branch
from
0f38629 to
cd3529b
Compare
|
We need to split into 2 commits. We cannot have the README and a new job in the same commit. |
This commit adds a script for checking the schema of LAVA job templates. The test is executed using the LAVA code from lava_common.schemas.validate. Script is executed using lava-server container in version that corresponds to the LAVA server running the actual tests in CI. Signed-off-by: Milosz Wasilewski <[email protected]>
This commit adds README.md describing the usage and constraints of the test job templates in ci/lava directory. Signed-off-by: Milosz Wasilewski <[email protected]>
mwasilew
force-pushed
the
ci-lava-readme
branch
from
cd3529b to
3d81eef
Compare
|
I pushed a new version with 2 commits |
No description provided.