Bug fixes for tear sheet plots #687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "turnover_denom" param when calling "create_txn_tear_sheet" from "create_full_tear_sheet"
Deleted "ax.set_ylim((0, 2))" from plot_turnover because daily turnover can be over 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix 1 (
tears.py)In
create_full_tear_sheetfunction,turnover_denomwas not passed tocreate_txn_tear_sheetfunction (so this fix added it).Without this fix,
plotting.plot_turnoverandplotting.plot_daily_turnover_histuse the default value of'AGB'when they are called fromcreate_full_tear_sheet(viacreate_txn_tear_sheet).Bug fix 2 (
plotting.py)Deleted
ax.set_ylim((0, 2))fromplot_turnoverfunction, because daily turnover can be over 2.