[verifier] [bug] Fix a bug when removing common prefix gates and do not generate hashing distribution in test_optimization_steps.h #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
Verifier::equivalent
when removing common prefix gates, that if the first circuit is a prefix of the second circuit, this function would also remove the entire second circuit before this PR. After this PR, this function will correctly keep the remaining part of the second circuit.This PR also avoids generating the hashing distribution in
test_optimization_steps.h
. The hashing distribution is only forCircuitSeq::hash()
, and it takes up space of Theta(2^num_qubits). This size is huge when the number of qubits is greater than 30. We can test circuits with more than 30 qubits after this PR.Also adds some debugging output when
verbose
is true.