Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add txBodyDigest to Tick struct #71

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add txBodyDigest to Tick struct #71

wants to merge 4 commits into from

Conversation

fnordspace
Copy link
Contributor

@fnordspace fnordspace commented Feb 25, 2025 •
edited
Loading

Adjustment of Tick struct to accommodate saltedTxBodyDigest added in commit qubic/core@55d5bb6 to the core.

@fnordspace fnordspace added the enhancement New feature or request label Feb 25, 2025
@fnordspace fnordspace self-assigned this Feb 25, 2025
@philippwerner
Copy link
Contributor

I think it would be useful to have checking of the saltedTransactionBodyDigest, like in verifyVoteWithSalt(). If it is too much work for now, you may create a ticket in the backlog.

We should not merge this Wednesday 12 UTC (not much earlier).

@fnordspace fnordspace changed the title Add txBodyDigest to Tick Stuct Add txBodyDigest to Tick struct Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krypdkat krypdkat Awaiting requested review from krypdkat

@philippwerner philippwerner Awaiting requested review from philippwerner

Assignees

@fnordspace fnordspace

Labels
enhancement New feature or request
Projects
qubic
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fnordspace @philippwerner