Issue-70 Fix the repartitioning logic to handle statement IDs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For UPDATE/DELETE, we were repartitioning based on encoded bucketIds so that all rows with same bucket are processed by the same task. However, rows can have same bucket but different encoded bucketIds as encoded bucketIds are composed of both bucket+statementId. Hence, row with same bucket end up going to different tasks which can cause conflict as different task will be writing to the same delete delta bucket file. Approved-by: Sourabh Goyal <[email protected]>
amoghmargoor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UPDATE/DELETE, we were repartitioning based on encoded bucketIds so that all rows with same bucket are processed by the same task.
However, rows can have same bucket but different encoded bucketIds as encoded bucketIds are composed of both bucket+statementId.
Hence, row with same bucket end up going to different tasks which can cause conflict as different task will be writing to the same delete delta bucket file.
CPed from SPAR-4637