Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR support #202

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

SSR support #202

wants to merge 3 commits into from

Conversation

FallenRiteMonk
Copy link
Contributor

Due to lack of time, I wasn't able to test this aproprietly, but this should fix #108.

@quentin-ol since this will not break any existing application, could you please merge this so I can try it easily without having to set up server side rendering (SSR) for your example project.

If not I'll hopefully find some time in near future to test this.

Further on, in combination with the proposal you made in #108 (comment), this could be extended to render a 'alt-img' if rendered on a server, making this module fully SSR capable.

@Gabb1995
Copy link

Gabb1995 commented Apr 2, 2019

any updates on this?

@MarouaniALA
Copy link

any news on this?

@MarouaniALA
Copy link

Hi @FallenRiteMonk can you plz help for this?

@FallenRiteMonk
Copy link
Contributor Author

@MarouaniALA I'm sorry but currently I'm short on time.

Copy link
Contributor

@davinkevin davinkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I comment to remove this old pr from my review list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants