feat: view form validation errors with no mapped element

classes/api/package_api.php

@@ -242,6 +242,8 @@ private function post_and_maybe_retry(string $uri, array $options = [], bool $al
     /**
      * Creates the multipart parts array.
      *
+     *
+     *
      * @param array $main main JSON part
      * @param string|null $questionstate optional question state
      * @return array

classes/api/qpy_http_client.php

@@ -48,6 +48,7 @@ class qpy_http_client extends http_client {
     public function __construct(array $config = []) {
         $config['base_uri'] ??= rtrim(get_config('qtype_questionpy', 'server_url'), '/') . '/';
         $config[RequestOptions::TIMEOUT] ??= get_config('qtype_questionpy', 'server_timeout');
+
         parent::__construct($config);
     }
 
@@ -63,7 +64,6 @@ public function __construct(array $config = []) {
      * @return ResponseInterface
      * @throws GuzzleException
      * @throws request_error
-     * @throws options_form_validation_error
      */
     public function get($uri, array $options = []): ResponseInterface {
         return parent::get($uri, $options);
@@ -80,7 +80,6 @@ public function get($uri, array $options = []): ResponseInterface {
      * @return ResponseInterface
      * @throws GuzzleException
      * @throws request_error
-     * @throws options_form_validation_error
      */
     public function post($uri, array $options = []): ResponseInterface {
         return parent::post($uri, $options);

edit_questionpy_form.php

@@ -64,7 +64,6 @@ public function __construct(string $submiturl, object $question, object $categor
                                 bool $formeditable = true) {
         $this->api = di::get(api::class);
         $this->packagefileservice = di::get(package_file_service::class);
-
         parent::__construct($submiturl, $question, $category, $contexts, $formeditable);
     }
 
@@ -312,6 +311,8 @@ public function set_data($question): void {
      * @throws moodle_exception
      */
     private function validate_options_form(array $data, ?stored_file $package, array &$errors): void {
+        $errorswithnoelement = [];
+
         try {
             $packagehash = $data['qpy_package_hash'] ?? $data['qpy_package_file_hash'];
             // TODO: create a dedicated endpoint?
@@ -321,9 +322,24 @@ private function validate_options_form(array $data, ?stored_file $package, array
                 $element = 'qpy_form[' . str_replace('.', '][', $field) . ']';
                 if ($this->_form->elementExists($element)) {
                     $errors[$element] = $error;
+                } else {
+                    $errorswithnoelement[$element] = $error;
                 }
             }
         }
+
+        if (!empty($errorswithnoelement)) {
+            $content = '';
+            foreach ($errorswithnoelement as $element => $error) {
+                $content .= get_string('options_form_validation_error_element', 'qtype_questionpy', [
+                    'name' => $element,
+                    'error' => $error,
+                ]);
+            }
+            $composederrorstring = get_string('options_form_validation_error_container', 'qtype_questionpy', $content);
+            // Use the 'Question name' input field to view the errors.
+            $errors['name'] = $composederrorstring;
+        }
     }
 
     /**

lang/en/qtype_questionpy.php

@@ -38,6 +38,9 @@
 $string['max_package_size_kb'] = 'Maximum file size of a QuestionPy package';
 $string['max_package_size_kb_description'] = 'Maximum file size in kB';
 $string['open_website'] = 'Open website';
+$string['options_form_validation_error_container'] = 'The following errors occurred while validating the form and could not'
+    . ' be mapped to an input element: <ul>{$a}</ul>';
+$string['options_form_validation_error_element'] = '<li>{$a->name}: {$a->error}</li>';
 $string['package_not_found'] = 'The requested package {$a->packagehash} does not exist.';
 $string['packages_subheading'] = 'Packages';
 $string['pluginname'] = 'QuestionPy';

version.php

@@ -25,7 +25,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'qtype_questionpy';
-$plugin->version = 2024101700;
+$plugin->version = 2024101704;
 $plugin->requires = 2024042200;
 $plugin->maturity = MATURITY_ALPHA;
 $plugin->release = '0.1';