Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Gravity with subcycling #499

Draft
wants to merge 77 commits into
base: development
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
bede28e
add prototype poisson gravity (does not yet compile)
Jan 10, 2022
7fe1df7
include AMRLevelOrion for reference
Jan 10, 2022
ca786bf
clean up gravity, style fixes
Jan 10, 2022
e298ae7
add note about changes from original code
Jan 10, 2022
f533477
URHO -> density_index, other changes
Jan 10, 2022
81036d6
remove most AmrLevel usage from gravity code
Jan 11, 2022
baa2245
templatify Gravity class
Jan 11, 2022
aba8638
clean-up gravity headers
Jan 11, 2022
eee7946
quokka-fication of gravity code
Jan 11, 2022
d0b4f5d
builds, but assertion failure
Jan 12, 2022
a1362e6
use sim->boxArray when possible
Jan 12, 2022
41e7ee7
fix bugs
Jan 12, 2022
c7ad4b2
add debugging for non-cell-centered rhs bug
Jan 13, 2022
aab9dc8
fix bug caused by calling surroudingNodes(dir) on sim->grids
Jan 13, 2022
07015af
fix const issues with .surroundingNodes(dir)
Jan 13, 2022
05b7469
revert CMakeLists changes
Jan 13, 2022
61cf57d
fix headers for gravity code
Jan 13, 2022
adc173b
added TODO
Jan 13, 2022
1a86493
fix implicit capture of this
BenWibking Jan 13, 2022
6e2ba07
use if constexpr for AMREX_SPACEDIM conditions
Jan 13, 2022
138cd6c
remove if constexpr use that nvcc does not support
Jan 13, 2022
b9c71c7
set tolerance before solve
BenWibking Jan 14, 2022
41755f9
use smooth test problem from MLC thesis
BenWibking Jan 14, 2022
2c980b3
add reference solution to PoissonFreeSpace
BenWibking Jan 17, 2022
1d61169
remove symmetric bc support
BenWibking Jan 17, 2022
5d7e678
cleanup gravity headers
BenWibking Jan 17, 2022
5b590b1
move mass off-center
BenWibking Jan 17, 2022
0853d69
fix set_numpts_in_gravity
BenWibking Jan 17, 2022
e436af9
call construct_new_gravity
BenWibking Jan 17, 2022
1a7c88b
do composite solve in test problem
BenWibking Jan 17, 2022
4478d4b
move gravity_sync() to new file
BenWibking Jan 17, 2022
ce6845f
compute residual for each level
BenWibking Jan 17, 2022
4405adb
add 256^3 poisson params
BenWibking Jan 17, 2022
f37a8b1
code cleanup
Jan 17, 2022
e1c5f37
add ErrorEst to PoissonFreeSpace
Jan 17, 2022
1983e78
fix off-by-one indexing error, add refinement to PoissonFreeSpace
BenWibking Jan 18, 2022
512964f
fix bugs in construct_old_gravity, construct_new_gravity
BenWibking Jan 18, 2022
1744bd7
debugging single-level solves
Jan 18, 2022
fc95d44
fix uninitialized values in grad_phi_curr[i]
Jan 18, 2022
efbd787
use more multipoles
Jan 18, 2022
e4dea30
adjust test pass tolerance
Jan 18, 2022
2685671
update max_grid_size
BenWibking Jan 18, 2022
3681bcb
move level solves to Gravity_level.hpp
BenWibking Jan 18, 2022
b4e840c
clean up headers
Jan 19, 2022
bf61800
only compute level corrections when needed
Jan 19, 2022
8771cd7
no ghost cells for grad_phi are needed
BenWibking Jan 20, 2022
54b68c9
bugfix
BenWibking Jan 20, 2022
f806310
add debugging info for level solves
BenWibking Jan 21, 2022
e723083
disable sync solve for testing
BenWibking Jan 21, 2022
a7a9f10
clean up gravity headers
BenWibking Jan 21, 2022
c566279
remove mlmg_nsolve
BenWibking Jan 21, 2022
378239f
disable some debugging
BenWibking Jan 21, 2022
d343cac
remove sync solve code -- that is now in a separate PR
BenWibking Jan 21, 2022
a007d32
skeleton methods for gravity sources in RadhydroSimulation
BenWibking Jan 21, 2022
5b7bb34
update submodules
BenWibking Dec 3, 2022
8f4b694
Merge branch 'development' into poisson-gravity
BenWibking Dec 3, 2022
23da00d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 3, 2022
fdb5785
fix bad merge
BenWibking Dec 3, 2022
0ed24b1
resolved conflicts
Jan 14, 2024
2ad582d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 14, 2024
d91aace
added amrex:: to Vectors, GpuArrays, Array4s, MultiFabs
Jan 14, 2024
04c015a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 14, 2024
f3c14b4
add remaining amrex:: to multifabs
Jan 14, 2024
d33e1ad
fix bug
Jan 14, 2024
ac31480
fix typo
Jan 14, 2024
db307c8
add remaining 3 arguments to FillCoarsePatch
Jan 14, 2024
8ed67b6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 14, 2024
ce7eaca
more updates
Jan 14, 2024
216c6cd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 14, 2024
1577582
Merge branch 'development' into subcycling
psharda Jan 14, 2024
02fa2e6
removed gravity BC files
Jan 14, 2024
57f07e4
remove multipole
Jan 14, 2024
8e5b659
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 14, 2024
e0cb3ae
uce bcs_cc in gravity
Jan 14, 2024
dc8c77d
remove multipole stuff
Jan 15, 2024
1d9544f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 15, 2024
3013235
remove old decl
Jan 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,18 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
set(CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake ${PROJECT_SOURCE_DIR}/extern/amrex/Tools/CMake)
include(CTest)

set(AMReX_SPACEDIM 1 CACHE STRING "")
set(AMReX_SPACEDIM 3 CACHE STRING "" FORCE)
set(AMReX_MPI ON CACHE BOOL "" FORCE)
set(AMReX_HDF5 OFF CACHE BOOL "" FORCE) # do not use
set(AMReX_LINEAR_SOLVERS ON CACHE BOOL "" FORCE)
set(AMReX_CONDUIT OFF CACHE BOOL "") # optional
set(AMReX_ASCENT OFF CACHE BOOL "") # optional
set(AMReX_AMRLEVEL OFF CACHE BOOL "" FORCE)
set(AMReX_PROBINIT OFF CACHE BOOL "" FORCE)
set(AMReX_LINEAR_SOLVERS ON CACHE BOOL "" FORCE)
set(AMReX_ASSERTIONS OFF CACHE BOOL "" FORCE)
set(AMReX_FPE OFF CACHE BOOL "" FORCE)
set(AMReX_TINY_PROFILE ON CACHE BOOL "" FORCE)
set(AMReX_TINY_PROFILE OFF CACHE BOOL "" FORCE)

## a Python installation can be specified with Python_ROOT_DIR
## see: https://cmake.org/cmake/help/latest/module/FindPython.html#hints
Expand Down
1 change: 1 addition & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ add_subdirectory(PrimordialChem)
add_subdirectory(Advection)
add_subdirectory(Advection2D)
add_subdirectory(AdvectionSemiellipse)
add_subdirectory(PoissonFreeSpace)


add_subdirectory(HydroBlast2D)
Expand Down
1 change: 1 addition & 0 deletions src/Gravity.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "Gravity.hpp"
Loading
Loading