fix(quotes): properly check for author id

This commit solves an issue where author existence check was not performed if author id was 0 (zero) - a falsy value. Now it checks only for None
quotepedia · Jan 11, 2025 · 2d0ae1a · 2d0ae1a
1 parent d45e090
commit 2d0ae1a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/api/quotes/routes.py b/src/api/quotes/routes.py
@@ -18,7 +18,7 @@ def create_quote(
     quote_service: QuoteServiceDepends,
     author_service: AuthorServiceDepends,
 ):
-    if args.author_id and not author_service.get_author_by_id(args.author_id):
+    if args.author_id is not None and not author_service.get_author_by_id(args.author_id):
         raise HTTPException(status.HTTP_404_NOT_FOUND, _("No author found with the ID '%s'." % (args.author_id,)))
     return quote_service.create_quote(args, created_by_user_id=current_user.id)