-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle axe violations issues resolved #506
base: master
Are you sure you want to change the base?
Conversation
mohanqxf2
commented
Jan 17, 2025
- Updated the snapshot_util.py to handle the resolved, updated axe accessibility violations and displayed a better message for users.
I have tested the following cases:
Update the node item/violation data, Here in this case I have updated 2015 to 2025
Remove the Node item in the existing snapshot to test this case.
Add the Node item in the existing snapshot to test this case. |
@mohanqxf2 If the violation gets removed shouldn't the test status be Passed with a message to the user to update the snapshot? |
@mohanqxf2 The tests that you performed aren't complete. You can try other conditions too like
I could find some issues with these tests |
|
For this case, need to slightly change the logic part, as of now the snapshots are comparing with each other, if any changes found then the test will be failed, if matches then the test will pass I will update the login to handle if any violations/nodes resvoled, then the test should be pass[for this case, the current and existing snapshot will not match because of violation will be resolved in the current snapshot] |