assignment_linter() gains operator= argument to allow, e.g. '=' assignments #2711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2698 and #2521. h/t again @J-Moravec for getting the ball rolling here.
Closes #2441.
This also un-couples the linted operator from the
allow_trailing
behavior; lints generated by the operator used are now independent of lints generated by line-trailing assignment operators:Having
<<-
allowed by default is back-compatible, but does strike me as odd -- should we also plan to remove this from the defaults?