-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include file names in challenge_uncommited_changes()
#2001
Open
olivroy
wants to merge
12
commits into
r-lib:main
Choose a base branch
from
olivroy:challenge-uncommited-tweaks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
Challenge uncommited tweaks in message
Tweak wording in Jun 9, 2024
challenge_uncommited_changes()
olivroy
changed the title
Tweak wording in
Include file names in Jun 26, 2024
challenge_uncommited_changes()
challenge_uncommited_changes()
I think this is a good pattern to reuse in this scenario:
This is ultimately coming from |
olivroy
force-pushed
the
challenge-uncommited-tweaks
branch
from
August 15, 2024 21:14
87cd0e9
to
54e13c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to make the message shorter, and more focused on current situation.
Adding a
which
argument that conflicts withmsg
.Rephrase message to be shorter.
Add a link to the uncommited files with
{.file
.format_inline()
will shorten automatically as needed.I think it is worth adding files in the message, since it can facilitate the choice.
Let me know what you think!
This PR:
Before
Yields the following message (instead of the correctly formatted with ! before.