Merge changes from fork into development branch for review #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor: add utility functions for checking gpkg files, connecting to gpkg files, updating tables, and checking for the existence of rows after a query
- refactor: add check_timestamp + fmt_timestamp helper functions - style: convert to markdown style roxygen - refactor: switch to use utility functions (e.g. update_gpkg_table)
- docs: add Imports + add contributor - docs: update function documentation
- feat(read_gpkg): add quiet parameter - fix(read_gpkg): replace reference to DBI w/ RSQLite
- refactor(amend_timestamp): deprecate verbose arg + rename has_query_rows utility function to has_query_min_rows - feat: make data available onLoad - refactor: move check_table_exists + update_gpkg_table
- refactor(read_gpkg_extension): incorporate reference data for extensions as a lookup table for table_name values - feat(read_gpkg_extension): add read_gpkg_related_tables variant - feat: add draft use_gpkg_extension - refactor: add helper extension_tables and extension_table_names functions
- refactor: update NAMESPACE + DESCRIPTION - test: add test for read_gpkg_contents + sample empty.gpkg file
|
Hi Eli, I'll merge right away since indeed your aim is to continue your work in a dev branch here. BTW an alternative to this PR is defining r-spatial/rgeopackage as an extra remote in your local git repo, and push your branch directly here, but of course that's not needed anymore. You now also have the option to clone the r-spatial repo as new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot in this request so I thought it would be better to merge into a development branch to keep working on it in the main repository and either merge piecemeal or just when it is ready. Here is a quick run-down:
Once this PR is merged, I think we can rename the master branch to main and then start pulling these changes into main.