feat(pop-api): errors #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwht
commented
Mar 4, 2024
evilrobot-01
force-pushed
the
frank/feat-pop-api-error
branch
2 times, most recently
from
609e476
to
21b2050
Compare
evilrobot-01
approved these changes
Mar 5, 2024
|
@peterwht unable to add you as a reviewer, presumable based on you creating the PR. Please can you give it another look after I addressed your comments? |
al3mart
approved these changes
Mar 5, 2024
|
LGTM! |
evilrobot-01
force-pushed
the
frank/feat-pop-api-error
branch
3 times, most recently
from
63da428
to
53a972d
Compare
evilrobot-01
force-pushed
the
feat/pop-api
branch
from
d5a777e
to
0f0b898
Compare
* ci: add build workflow * chore: improve zombienet config * ci: grant write permission to actions * feat: initialize pop-api directory * feat: add codec indexes, and wrap NFT interface * feat: add example contract utilizing pop-api crate -- not working * feat: minting NFT from contract through runtime works * feat pop api crate refactoring and test (#15) * refactor: simplify api usage from contract * test: add NFT mint unit test to pop api extension --------- Co-authored-by: Frank Bell <[email protected]> --------- Co-authored-by: Frank Bell <[email protected]>
* demo_contract:query_runtime * pop-api-ext:query * read relay_block# & state * unused import * ci: add build workflow * chore: improve zombienet config * ci: grant write permission to actions * feat: initialize pop-api directory * feat: add codec indexes, and wrap NFT interface * feat: add example contract utilizing pop-api crate -- not working * feat: minting NFT from contract through runtime works * feat: generic state reads * chore: fmt * RuntimeStateKeys * clean keys * fmt * cumulus_parachain_system is accessible --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Peter White <[email protected]>
evilrobot-01
force-pushed
the
frank/feat-pop-api-error
branch
from
53a972d
to
ffefc61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error handling approach to surface pallet errors from runtime calls.