feat(messaging): callbacks #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al3mart
reviewed
Nov 6, 2024
| Ok(()) | ||
| } | ||
|
|
||
| #[pallet::call_index(3)] | ||
| #[pallet::weight(Weight::zero())] // todo: benchmarking after consolidating storage | ||
| #[pallet::weight(Weight::zero() // todo: benchmarking after consolidating storage | ||
| // Add any additional gas limit specified for callback execution |
al3mart
approved these changes
Nov 6, 2024
| data: &impl Encode, | ||
| deposit: BalanceOf<T>, | ||
| ) -> DispatchResult { | ||
| // TODO: check weight removed from block weight - may need dispatching via executive |
There was a problem hiding this comment.
may need dispatching via executive
Curious about this one. The weight would be at least the corresponding to executing the Callback plus the resulting of execution this function, right ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional callback specification when using the messaging API. See the messaging contract within pop-api/integration-tests/contracts for usage.