Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fetchBlob): add fetchBlob API for produce fetch for blob response #28

Merged
merged 2 commits into from
Oct 3, 2022
Merged

feat(fetchBlob): add fetchBlob API for produce fetch for blob response #28

merged 2 commits into from
Oct 3, 2022

Conversation

Lzyct
Copy link
Contributor

@Lzyct Lzyct commented Oct 3, 2022

#22 for fetchBlob API

r17x
r17x requested changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@r17x r17x left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing add expression for called blob in blobRespnse. @Lzyct
see here or another example here

@r17x
Copy link
Owner

r17x commented Oct 3, 2022

@all-contributors add @Lzyct as code and example

@allcontributors allcontributors bot mentioned this pull request Oct 3, 2022
Merged
@allcontributors
Copy link
Contributor

@r17x

I've put up a pull request to add @Lzyct! 🎉

@kodiakhq kodiakhq bot merged commit 962ed11 into r17x:main Oct 3, 2022
kodiakhq bot pushed a commit that referenced this pull request Oct 3, 2022
@allcontributors
docs: add Lzyct as a contributor for code, and example (#29)
2f90047 
Adds @Lzyct as a contributor for code, example.

This was requested by r17x [in this comment](#28 (comment))
@r17x r17x mentioned this pull request Oct 3, 2022
Closed
6 tasks
github-actions bot pushed a commit that referenced this pull request Oct 3, 2022
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
e1cdbf5 
# [1.4.0](v1.3.0...v1.4.0) (2022-10-03)

### Features

* **fetchBlob:** add fetchBlob API for produce fetch for blob response ([#28](#28)) ([962ed11](962ed11)), closes [#22](#22)
@r17x
Copy link
Owner

r17x commented Oct 3, 2022

true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x requested changes

Assignees
No one assigned
Labels
automerge hacktoberfest kodiak: merge.method = 'squash' merge squash released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lzyct @r17x