Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 24-web_scraping.Rmd #129

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Conversation

andrewypua-projects
Copy link
Contributor

Request from Andrew Pua of r4ds Cohort 09 to add presented material to Chapter 24 Hierarchical Data.

Request from Andrew Pua of r4ds Cohort 09 to add presented material to Chapter 24 Hierarchical Data.
Copy link
Collaborator

@Ken-Vu Ken-Vu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Andrew. Can you move the sections labeled Cohort 8 and Cohort 9 to the end of the presentation? Thanks!

@lgibson7
Copy link
Member

lgibson7 commented Apr 1, 2024

@andrewypua-projects @Ken-Vu . I'll update it. Thank you!

@andrewypua-projects
Copy link
Contributor Author

I found the error for this part. I may have to put eval: FALSE in some places.

@lgibson7
Copy link
Member

lgibson7 commented Apr 3, 2024

There'd be a lot of edits needed to make the Loading IMBD data example render. If you are willing to make the edits @andrewypua-projects, please do. Otherwise, we can leave the chapter as is and cohort 10 can update when they get up to it.

Put in eval: FALSE in the relevant places so that the file could be rendered.
Moved cohort videos to end of book slides and removed slide templates
Ken-Vu
Ken-Vu previously approved these changes Apr 7, 2024
@Ken-Vu
Copy link
Collaborator

Ken-Vu commented Apr 7, 2024

@andrewypua-projects I moved the section Meeting Videos to the end of the presentation, which is something I recommend doing for consistency and keep the chapter less cluttered at the beginning. I also removed the slide templates as well.

Can you break up the section Example: Loading IMDB data into a series of smaller and shorter slides? Otherwise, the slides render fine and look good!

Tweaked the Learning Objectives section so they appear on title page.
Ken-Vu
Ken-Vu approved these changes Apr 7, 2024
@jonthegeek jonthegeek enabled auto-merge (squash) April 10, 2024 11:18
@jonthegeek jonthegeek merged commit 498e959 into r4ds:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants