Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Connext): Chain ID should be a number (not hex string) #18

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

jimobrien
Copy link
Member

@jimobrien jimobrien commented Aug 25, 2023

The transaction shape should conform to the viem TransactionEIP1559 type

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: d20aa93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jimobrien jimobrien merged commit c90f4d7 into main Sep 12, 2023
9 checks passed
Quazia added a commit that referenced this pull request Feb 16, 2024
* Fix(filter): graceful error handling of decoding

* Chore(filter): force lint
mmackz added a commit that referenced this pull request Mar 2, 2024
* delete test

* feat: add jojo stake plugin

* Chore: bump pnpm 8.15.3

* test

* Feat(zora): add simulateMint

* Feat(mirror): add simulateMint

* Feat(sound): add mintSimulate

* chore: format

* Chore: changeset

* Version Packages (alpha)

* add zod as a dev dependency

* add script

* add js-yaml

* update

* test

* commonjs

* things

* install types

* why not

* change

* logs

* drop catch

* set path

* add url to schema

* add test plugin

* chore: format

* update config

* add comment

* exit on error

* fill in details

* add check for new packages

* remove config

* add type notations

* branches

* target fork

* :(

* 1

* Feat(registry): add getTxSimulation to registry

* 2

* Chore: delete questk pnpm-workspace.yaml

* lfg

* types

* add details

* update message

* Fix: root tsconfig

* Fix: tweak root tsconfig

* chore: format

* Chore: changeset

* Chore: fully remove tsconfig from root

* update script

* Chore: remove per-app pnpm enforcement

* remove icon

* chore: version package (alpha)

* update

* update

* add details

* remove logs

* pass tests

* add branch

* test merge

* fix: delete TOKEN_JUSD

* Chore(utils): add sepolia to chain-ids

* Chore(types): make tokenId option for mint intent

* Fix(zora): update ABI, Save legacy mint in seperate ABI

* Feat(zora): add mint cop addresses

* Feat(utils): ADD TREASURY CONST

* Feat(zora): update intent/simulation with new contract

* Test(zora): simulation

* chore: format

* Chore: cleanup

* chore: format

* Fix: update simulation return types

* added export for tokens directory

* chore: format

* chore: format

* added changeset

* Test(zora): remove only

* Test(zora): update test data

* Chore(deps): bump codecov/codecov-action from 4.0.1 to 4.1.0

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.0.1...v4.1.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Refactor(zora): use viem pad over helper

Thanks for the tip @jonathandiep

* Chore(zora): remove stray log

* Chore: changeset

* refactor(jojo): remove template comments

* refactor(jojo): convert bigint to string value

* chore: version package (alpha)

* Fix(zora): remove extra msgArgs

* chore: version package (alpha)

* validateicon

* update action

* use ngrok for testing

* Fix config file format verification script

* update iconoption

* change ngrok url

* fix logo url

* fix logo url

* verify unique urls

* add env override

* add script to register plugin details

* change install node step

* fix namespace issue

* updatefail logic

* fix

* changes

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: almo <[email protected]>
Co-authored-by: Quazia <[email protected]>
Co-authored-by: Quazia <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: mmackz <[email protected]>
Co-authored-by: veganbeef <[email protected]>
Co-authored-by: veganbeef <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mmackz mmackz deleted the fix-connext-chainid branch March 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant