Feat(stargate): Stargate bridge #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef6b199 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jimobrien
reviewed
Sep 12, 2023
| ? CHAIN_AND_POOL_TO_TOKEN_ADDRESS[sourceChainId][tokenAddress] | ||
| : 0 | ||
|
|
||
| if (sourcePool === 13) { |
There was a problem hiding this comment.
is this const ETH_POOL = 13 accurate?
There was a problem hiding this comment.
Yep, I'll create a const and compare against that vs a magic number for increased clarity.
…into stargate_bridge
…stdk-plugins into stargate_bridge
…stdk-plugins into stargate_bridge
…into stargate_bridge
…into stargate_bridge
…stdk-plugins into stargate_bridge
…stdk-plugins into stargate_bridge
jimobrien
approved these changes
Sep 15, 2023
Merged
Quazia
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the data in
CHAIN_AND_POOL_TO_TOKEN_ADDRESSin thecontract-addresses.tsfile are the pool token instead of the actual token. Going to have to fix the data in that lookup before we merge this in.Fixed the
CHAIN_AND_POOL_TO_TOKEN_ADDRESSforUSDCUSDTandWETH. Should be G2G.