feat(sound): add getExternalUrl function #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0efba1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmackz
commented
Jul 16, 2024
| @@ -175,6 +176,7 @@ describe('simulateMint function', () => { | |||
| contractAddress: '0xdf71F2F15bCcDC7c7A89F01dd45cDE5A43F7e79f', | |||
| amount: BigInt(1), | |||
| recipient: '0xf70da97812CB96acDF810712Aa562db8dfA3dbEF', | |||
| referralAddress: '0xe3bba2a4f8e0f5c32ef5097f988a4d88075c8b48', | |||
There was a problem hiding this comment.
need to switch this to just referral
mmackz
commented
Jul 16, 2024
| @@ -201,3 +204,14 @@ describe('simulateMint function', () => { | |||
| expect(request.value).toBe(value) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('getExternalLink', () => { | |||
|
@jonathandiep I have made the recommended changes (added the referral param in external url) Could you take another pass when you get some time. 🙏 |
jonathandiep
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getExternalUrlfunction to sound pluginThis function is used to generate a external url on boost creation.
Fixes BOOST-4265
https://linear.app/rh-app/issue/BOOST-4265/implement-getexternalurl-in-plugins-sound