fix(zora): add tokenId to zora SDK getToken call for 1155s #511
Conversation
🦋 Changeset detectedLatest commit: 33ab22d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -471,6 +472,12 @@ export const getFees = async ( | |||
| publicClient: client, | |||
| }) | |||
|
|
|||
| // if contract type is 1155, we need to get the latest tokenId | |||
| if (contractType === '1155' && tokenId == null) { | |||
There was a problem hiding this comment.
if we pass tokenId into getNextTokenId it should account for the existing tokenId right? Neutral on if we pass it or implementation, important thing is that the simulation and fees are both using the same logic to determine the token to use (both use next if tokenId is undefined)
There was a problem hiding this comment.
getNextTokenId passes back the existing tokenId if it is defined.
Felt this was more semantic.
SimulateMint and getFees will both use getNextTokenId when no token is available.
mmackz
deleted the
matthew/boost-4477-zora-getfees-fails-for-1155-wo-tokenid-plugin
branch
getTokencall, otherwise it will fail and return the base fee.Fixes BOOST-4477
https://linear.app/rh-app/issue/BOOST-4477/zora-getfees-fails-for-1155-wo-tokenid-plugin