Add Ruby 3.4 to the CI #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santib
force-pushed
the
add-ruby-3-4
branch
3 times, most recently
from
08b6ce5 to
78e491b
Compare
grzuy
reviewed
Jan 22, 2025
| @@ -4,6 +4,9 @@ source "https://rubygems.org" | |||
|
|
|||
| gem "activesupport", "~> 6.1.0" | |||
| gem "redis", "~> 5.0" | |||
| gem "base64", "~> 0.2" | |||
| gem "bigdecimal", "~> 3.1" | |||
| gem "mutex_m", "~> 0.3" | |||
There was a problem hiding this comment.
Why this exactly?
Needed by ruby 3.4 on these "old" activesupport versions?
There was a problem hiding this comment.
Ruby 3.4 extracted out some parts into their own gems, and no longer require them by default. Rails/Minitest depend on these, so even if it's fixed for newer versions, the older versions will fail. So we can either choose to drop support for Ruby 3.4 + old versions, or we can backfill those missing dependencies. Let me know if you come up with a better idea of course 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.