chore(routes): Cleanup random, old, or misleading route files #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudnull
force-pushed
the
route-cleanup
branch
4 times, most recently
from
bb28ff9 to
b95d983
Compare
This change eliminates the embeded route files that we had in our services that 1) didn't work, 2) broken, 3) were misleading. All of route objects are now stored in the same place and fully documented as part of our normal deployment process. Signed-off-by: Kevin Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates the embeded route files that we had in our services that 1) didn't work, 2) broken, 3) were misleading. At best many of these route manifests did nothing, at worst it created an inconsistent deployment
experience, especially if the gateway setup was ever updated or changed without also rerunning the service deployment
helm charts.
All of route objects are now stored in the same place and fully documented as part of our normal deployment process.