Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ctp anonymizer basic beta #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Configure ctp anonymizer basic beta #2

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e4529a
Changed DICOM import port to 104 which is well known for DICOM traffic
maxicheong May 8, 2017
fb44327
Added DICOM S142 Basic Anonymization Profile, added patient ID and na…
maxicheong May 8, 2017
7052411
Really adding DICOM S142 Basic Anonymization Profile script now
maxicheong May 8, 2017
694c227
Created folder to store the CTP .script files
maxicheong May 8, 2017
9a4c145
Exposing port 104 where the DICOM incoming traffic is
maxicheong May 8, 2017
b157abb
During start, put in default anonymization pipeline by putting in the…
maxicheong May 9, 2017
32c63bb
Corrected startup jar to Runner.jar
maxicheong May 9, 2017
41f5869
Added line to start CTP DICOM server and pipeline
maxicheong May 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ RUN apt-get update && apt-get -y install git \
unzip

RUN mkdir /JavaPrograms
RUN mkdir /JavaPrograms/scripts
RUN mkdir /code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future, if you do just mkdir -p /JavaPrograms/scripts this will create both directories with one line. This is a good strategy to have for Dockerfiles, because each line is a separate layer. It's good practice to reduce your runs into as few layers as possible. Eg:

RUN mkdir -p /JavaPrograms/scripts && mkdir /code

would be more optimal, although not completely necessary :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Noted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah dawg! Check this out when you have time: https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/ it's really interesting what an "image" actually is, think "sandwich layers" vs. "entire sandwich" :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try typing:

docker images

and you'll see all the (top level) images.. then try

docker images --digests

and you'll see each image id is actually a sha256 sum! But it gets even better... do

docker images --all

and you'll see that each "image" is actually a crapton of layers, and they are only assembled when the image is actually running. Each layer is actually a diff off of the previous ones, and then at runtime the top layer is the only one that is actually writable that maintains your changes. This is a fundamentally different model than singularity, which is an actual, one file deal, image.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating concept of layers! Unlike VMs, I thought it was a one file deal.

WORKDIR /code
ADD . /code
Expand Down