Updates on skupper install and deploy workload roles #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the hello world example to adapt to the changes made on the following roles: - install_skupper - deploy_workload ## Motivation and Context This change is needed to use the new variables defined at the roles that will allow the installation of skupper to work properly and also identify either the workload deploy and skupper deploy to be identified by it's labels and count. ## How Has This Been Tested? Set the cluster details and the kubeconfig to ~/.kune/config in order to use the example default. ```bash make build make hello ``` ## Types of Changes - [X] Bug fix - [X] New feature ## Checklist: - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas Signed-off-by: Rafael Zago <[email protected]>
feat(skupper): Implement namespace and cluster scope installation ## Motivation and Context This commit refactors the Skupper installation role to support both namespace and cluster-scoped deployments. This provides greater flexibility for users and aligns with best practices for Kubernetes deployments. * Defaulting to the 'skupper-operator' namespace. * Dynamically generating the Skupper Helm chart using a Makefile. * Adding conditional logic to handle namespace and cluster scope installations. * Improving pod validation by using labels and the dynamic namespace. ## How Has This Been Tested? ```bash make build make hello``` ## Types of Changes - [X] Bug fix - [X] New feature - [X] Documentation change ## Checklist: - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [X] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [X] I have added tests that prove my fix is effective or that my feature works - [X] New and existing unit tests pass locally with my changes Signed-off-by: Rafael Zago <[email protected]>
fix(deploy_workload): Ensure all replicas are running before proceeding
## Motivation and Context
This commit enhances the deploy_workload role's readiness check by ensuring
that all replicas of the deployment are running before proceeding.
Previously, the task would succeed if *any* pod was running.
Key changes:
* Added a label selector (`app={{ deploy_workload_deployment_name }}`) to
target the correct pods.
* Modified the `until` condition to check if the number of
running pods matches `deploy_workload_replicas`.
This change ensures that the deployment is fully up and running before
the playbook continues.
## How Has This Been Tested?
```bash
make build
make hello
```
## Types of Changes
- [X] Bug fix
- [X] New feature
- [X] Documentation change
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
Signed-off-by: Rafael Zago <[email protected]>
Bumping version to 0.1.10 ## Motivation and Context Changes on several roles ## How Has This Been Tested? ```bash make build make test``` ## Types of Changes - [X] Other (please specify): Bumping version Signed-off-by: Rafael Zago <[email protected]>
Signed-off-by: Rafael Zago <[email protected]>
Signed-off-by: Rafael Zago <[email protected]>
Signed-off-by: Rafael Zago <[email protected]>
granzoto
reviewed
Feb 5, 2025
collections/ansible_collections/rhsiqe/skupper/roles/install_skupper/tasks/main.yml
Outdated
Show resolved
Hide resolved
labels. Improve Skupper pod wait tasks with label selectors and robust readiness check ## Motivation and Context It will cover reruns only looking to necessary pods. ## Types of Changes - [X] Bug fix ## Checklist: - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [X] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [X] I have added tests that prove my fix is effective or that my feature works - [X] New and existing unit tests pass locally with my changes Signed-off-by: Rafael Zago <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping version to 0.1.10
feat(skupper): Implement namespace and cluster scope installation
fix(deploy_workload): Ensure all replicas are running before proceeding
Changing the hello world example to adapt to the changes made on the
following roles:
Motivation and Context
This commit refactors the Skupper installation role to support both namespace
and cluster-scoped deployments. This provides greater flexibility for users
and aligns with best practices for Kubernetes deployments.
installations.
This commit enhances the deploy_workload role's readiness check by ensuring
that all replicas of the deployment are running before proceeding.
Previously, the task would succeed if any pod was running.
app={{ deploy_workload_deployment_name }}) totarget the correct pods.
untilcondition to check if the number ofrunning pods matches
deploy_workload_replicas.This change ensures that the deployment is fully up and running before
the playbook continues.
hanging the hello world example to adapt to the changes made on the
following roles:
This change is needed to use the new variables defined at the roles that
will allow the installation of skupper to work properly and also
identify either the workload deploy and skupper deploy to be identified
by it's labels and count.
How Has This Been Tested?
Types of Changes
Checklist: